Minor refactoring code cleanup

Author: lvca

engine/src/main/java/com/arcadedb/query/QueryEngineManager.java

@@ -16,44 +16,30 @@
 package com.arcadedb.query;
 
 import com.arcadedb.database.DatabaseInternal;
+import com.arcadedb.log.LogManager;
 import com.arcadedb.query.sql.SQLQueryEngine;
 
 import java.util.*;
+import java.util.logging.*;
 
 public class QueryEngineManager {
   private final Map<String, QueryEngine.QueryEngineFactory> implementations = new HashMap<>();
 
   public QueryEngineManager() {
-
+    // REGISTER QUERY ENGINES IF AVAILABLE ON CLASSPATH AT RUN-TIME
     register(new SQLQueryEngine.SQLQueryEngineFactory());
-    try {
-      QueryEngine.QueryEngineFactory engineFactory = (QueryEngine.QueryEngineFactory) Class.forName("com.arcadedb.gremlin.query.GremlinQueryEngineFactory")
-          .getConstructor().newInstance();
-      register(engineFactory);
-    } catch (Exception e) {
-//      LogManager.instance().log(this, Level.SEVERE, "Unable to register engine", e);
-    }
-    try {
-      QueryEngine.QueryEngineFactory engineFactory = (QueryEngine.QueryEngineFactory) Class.forName("com.arcadedb.gremlin.query.CypherQueryEngineFactory")
-          .getConstructor().newInstance();
-      register(engineFactory);
-    } catch (Exception e) {
-//      LogManager.instance().log(this, Level.SEVERE, "Unable to register engine", e);
-    }
-    try {
-      QueryEngine.QueryEngineFactory engineFactory = (QueryEngine.QueryEngineFactory) Class.forName("com.arcadedb.mongo.query.MongoQueryEngineFactory")
-          .getConstructor().newInstance();
-      register(engineFactory);
-    } catch (Exception e) {
-//      LogManager.instance().log(this, Level.SEVERE, "Unable to register engine", e);
-    }
 
+    register("com.arcadedb.gremlin.query.GremlinQueryEngineFactory");
+    register("com.arcadedb.gremlin.query.CypherQueryEngineFactory");
+    register("com.arcadedb.mongo.query.MongoQueryEngineFactory");
+    register("com.arcadedb.graphql.query.GraphQLQueryEngineFactory");
+  }
+
+  public void register(final String className) {
     try {
-      QueryEngine.QueryEngineFactory engineFactory = (QueryEngine.QueryEngineFactory) Class.forName("com.arcadedb.graphql.query.GraphQLQueryEngineFactory")
-          .getConstructor().newInstance();
-      register(engineFactory);
+      register((QueryEngine.QueryEngineFactory) Class.forName(className).getConstructor().newInstance());
     } catch (Exception e) {
-//      LogManager.instance().log(this, Level.SEVERE, "Unable to register engine", e);
+      LogManager.instance().log(this, Level.FINE, "Unable to register engine '%s' (%s)", className, e.getMessage());
     }
   }
 

engine/src/test/java/com/arcadedb/index/LSMTreeIndexTest.java

@@ -1055,17 +1055,14 @@ public void run() {
 
       LogManager.instance().log(this, Level.INFO, "COUNT OF INSERTED RECORDS (ORDERED BY ID)");
       final Map<Integer, Integer> result = new HashMap<>();
-      database.scanType(TYPE_NAME, true, new DocumentCallback() {
-        @Override
-        public boolean onRecord(Document record) {
-          final int id = (int) record.get("id");
-          Integer key = result.get(id);
-          if (key == null)
-            result.put(id, 1);
-          else
-            result.put(id, key + 1);
-          return true;
-        }
+      database.scanType(TYPE_NAME, true, record -> {
+        final int id = (int) record.get("id");
+        Integer key = result.get(id);
+        if (key == null)
+          result.put(id, 1);
+        else
+          result.put(id, key + 1);
+        return true;
       });
 
       LogManager.instance().log(this, Level.INFO, "FOUND %d ENTRIES", null, result.size());