WON-410-vve-brief-importer #191
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of "Vve cursus/deelnemers" importer is next, which should be followed by a proper meeting/coordination with the client to come to a finalized Excel/CSV structure and import flow. I'd say this 80% it, but probably needs refinement later on in the proces.
Changes:
LetterImporterclass under thehomeownerassociatonDjango app;import_contactsmanagement command, mainly for for manual testing right now, which will be superseded by an actual API (although both can live in parellel obviously);is_importedflag toHomeownerAssociationCommunicationNote, so we can more easily identify if it was imported (vs. created manually).is_imported=True. Thought matching it on exactdescriptionis risky, since any typo/change for an additional import would not match anymore. This addition could be a bit premature, but for now prevents me from having to delete many comm notes. Probably coordinating with the client in the near future could create a set of rules where we can prevent having to revert accidental (double, triple, etc...) imports (e.g. "Ow k*t, kunnen jullie deze 4000 communication notes toch verwijderen, want ik heb een foutje gemaakt"). Or we can simply await any import if there are no errors at all. Anyhow, to be refined... 🤞