Remove unjustified null-forgiving operator on MutatedInstance

Author: bjorntore

src/Altinn.App.Api/Controllers/InstancesController.cs

@@ -392,7 +392,7 @@ await _instanceClient.DeleteInstance(
             if (!startProcessResult.Success)
                 return Conflict(startProcessResult.ErrorMessage);
 
-            instance = startProcessResult.MutatedInstance!;
+            instance = startProcessResult.MutatedInstance;
         }
         catch (Exception exception)
         {
@@ -617,7 +617,7 @@ public async Task<ActionResult<InstanceResponse>> PostSimplified(
             );
             if (!startProcessResult.Success)
                 return Conflict(startProcessResult.ErrorMessage);
-            instance = startProcessResult.MutatedInstance!;
+            instance = startProcessResult.MutatedInstance;
         }
         catch (Exception exception)
         {
@@ -748,7 +748,7 @@ public async Task<ActionResult> CopyInstance(
         );
         if (!startProcessResult.Success)
             return Conflict(startProcessResult.ErrorMessage);
-        targetInstance = startProcessResult.MutatedInstance!;
+        targetInstance = startProcessResult.MutatedInstance;
 
         await RegisterEvent("app.instance.created", targetInstance);
 

src/Altinn.App.Api/Controllers/ProcessController.cs

@@ -158,7 +158,7 @@ public async Task<ActionResult<AppProcessState>> StartProcess(
                 return Conflict(startProcessResult.ErrorMessage);
             }
 
-            instance = startProcessResult.MutatedInstance!;
+            instance = startProcessResult.MutatedInstance;
 
             AppProcessState appProcessState = await ConvertAndAuthorizeActions(instance, instance.Process);
             return Ok(appProcessState);

src/Altinn.App.Core/Models/Process/ProcessChangeResult.cs

@@ -13,6 +13,7 @@ public class ProcessChangeResult
     /// Gets or sets a value indicating whether the process change was successful
     /// </summary>
     [MemberNotNullWhen(true, nameof(ProcessStateChange))]
+    [MemberNotNullWhen(true, nameof(MutatedInstance))]
     [MemberNotNullWhen(false, nameof(ErrorMessage), nameof(ErrorType))]
     public bool Success { get; init; }
 

test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

@@ -4857,14 +4857,17 @@ namespace Altinn.App.Core.Models.Process
         [System.Diagnostics.CodeAnalysis.MemberNotNullWhen(false, new string?[]?[] {
                 "ErrorMessage",
                 "ErrorType"})]
+        [System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "MutatedInstance")]
         [System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "ProcessStateChange")]
         [get: System.Diagnostics.CodeAnalysis.MemberNotNullWhen(false, new string?[]?[] {
                 "ErrorMessage",
                 "ErrorType"})]
+        [get: System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "MutatedInstance")]
         [get: System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "ProcessStateChange")]
         [set: System.Diagnostics.CodeAnalysis.MemberNotNullWhen(false, new string?[]?[] {
                 "ErrorMessage",
                 "ErrorType"})]
+        [set: System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "MutatedInstance")]
         [set: System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "ProcessStateChange")]
         public bool Success { get; init; }
         public System.Collections.Generic.List<Altinn.App.Core.Models.Validation.ValidationIssueWithSource>? ValidationIssues { get; set; }