From 62af52348c3faea6e683150c4960d383718aef6f Mon Sep 17 00:00:00 2001
From: Vasily Nemkov <V.Nemkov@gmail.com>
Date: Wed, 7 Feb 2024 16:39:01 +0100
Subject: [PATCH 1/3] Attempt to fix BuilderReport

download only `build_report_*.json` artifacts, since it looks like
other artifacts can't be processed by tests/ci/build_report_check.py
---
 .github/workflows/release_branches.yml | 1 +
 .github/workflows/reusable_test.yml    | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/release_branches.yml b/.github/workflows/release_branches.yml
index 256dd638dca4..5e4e0f068416 100644
--- a/.github/workflows/release_branches.yml
+++ b/.github/workflows/release_branches.yml
@@ -188,6 +188,7 @@ jobs:
       test_name: ClickHouse build check
       runner_type: style-checker, on-demand, type-cpx31, image-x86-app-docker-ce
       timeout_minutes: 180
+      download_artifacts_pattern: build_report_*.json
       additional_envs: |
         NEEDS_DATA<<NDENV
         ${{ toJSON(needs) }}
diff --git a/.github/workflows/reusable_test.yml b/.github/workflows/reusable_test.yml
index c20f32bc9f88..e0c27b18e55a 100644
--- a/.github/workflows/reusable_test.yml
+++ b/.github/workflows/reusable_test.yml
@@ -38,6 +38,10 @@ name: Testing workflow
       additional_envs:
         description: additional ENV variables to setup the job
         type: string
+      download_artifacts_pattern:
+        description: A glob pattern to the artifacts that should be downloaded. (see https://github.com/actions/download-artifact `pattern`)
+        type: string
+        required: false
     secrets:
       secret_envs:
         description: if given, it's passed to the environments
@@ -155,8 +159,9 @@ jobs:
           job_type: test
 
       - name: Download json reports
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
+          pattern: ${{ inputs.download_artifacts_pattern }}
           path: ${{ env.REPORTS_PATH }}
 
       - name: Docker setup

From 0a7388a917f802dca227f3b26006a2120f4d8374 Mon Sep 17 00:00:00 2001
From: Vasily Nemkov <V.Nemkov@gmail.com>
Date: Wed, 7 Feb 2024 20:01:11 +0100
Subject: [PATCH 2/3] Attempt to fix BuilderReport download artifact pattern

Also starting BuilderReport before regression tests to make it pass or
fail faster
---
 .github/workflows/release_branches.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/release_branches.yml b/.github/workflows/release_branches.yml
index 5e4e0f068416..6ee6ab86e586 100644
--- a/.github/workflows/release_branches.yml
+++ b/.github/workflows/release_branches.yml
@@ -188,7 +188,7 @@ jobs:
       test_name: ClickHouse build check
       runner_type: style-checker, on-demand, type-cpx31, image-x86-app-docker-ce
       timeout_minutes: 180
-      download_artifacts_pattern: build_report_*.json
+      download_artifacts_pattern: build_report_*
       additional_envs: |
         NEEDS_DATA<<NDENV
         ${{ toJSON(needs) }}
@@ -311,7 +311,7 @@ jobs:
 ##################################### REGRESSION TESTS ######################################
 #############################################################################################
   RegressionTestsRelease:
-    needs: [BuilderDebRelease]
+    needs: [BuilderReport]
     uses: ./.github/workflows/regression.yml
     secrets: inherit
     with:
@@ -321,7 +321,7 @@ jobs:
       build_sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.event_name == 'release' && github.sha }}
 
   RegressionTestsAarch64:
-    needs: [BuilderDebAarch64]
+    needs: [BuilderReport]
     uses: ./.github/workflows/regression.yml
     secrets: inherit
     with:

From dacb4929b9b1cba14329eeff36886700adf5af78 Mon Sep 17 00:00:00 2001
From: Vasily Nemkov <V.Nemkov@gmail.com>
Date: Thu, 8 Feb 2024 09:39:36 +0100
Subject: [PATCH 3/3] removed download_artifacts_pattern

---
 .github/workflows/release_branches.yml | 1 -
 .github/workflows/reusable_test.yml    | 7 +------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/.github/workflows/release_branches.yml b/.github/workflows/release_branches.yml
index 6ee6ab86e586..299311c4dc8c 100644
--- a/.github/workflows/release_branches.yml
+++ b/.github/workflows/release_branches.yml
@@ -188,7 +188,6 @@ jobs:
       test_name: ClickHouse build check
       runner_type: style-checker, on-demand, type-cpx31, image-x86-app-docker-ce
       timeout_minutes: 180
-      download_artifacts_pattern: build_report_*
       additional_envs: |
         NEEDS_DATA<<NDENV
         ${{ toJSON(needs) }}
diff --git a/.github/workflows/reusable_test.yml b/.github/workflows/reusable_test.yml
index e0c27b18e55a..c20f32bc9f88 100644
--- a/.github/workflows/reusable_test.yml
+++ b/.github/workflows/reusable_test.yml
@@ -38,10 +38,6 @@ name: Testing workflow
       additional_envs:
         description: additional ENV variables to setup the job
         type: string
-      download_artifacts_pattern:
-        description: A glob pattern to the artifacts that should be downloaded. (see https://github.com/actions/download-artifact `pattern`)
-        type: string
-        required: false
     secrets:
       secret_envs:
         description: if given, it's passed to the environments
@@ -159,9 +155,8 @@ jobs:
           job_type: test
 
       - name: Download json reports
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v3
         with:
-          pattern: ${{ inputs.download_artifacts_pattern }}
           path: ${{ env.REPORTS_PATH }}
 
       - name: Docker setup