Skip to content

Commit 8ac4341

Browse files
ianton-ruEnmk
authored andcommitted
Fixes after few comments
1 parent 46fa2d1 commit 8ac4341

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

src/Interpreters/ClusterProxy/executeQuery.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ void executeQuery(
442442
not_optimized_cluster->getName());
443443

444444
read_from_remote->setStepDescription("Read from remote replica");
445-
read_from_remote->setRemoteFunction(is_remote_function);
445+
read_from_remote->setIsRemoteFunction(is_remote_function);
446446
plan->addStep(std::move(read_from_remote));
447447
plan->addInterpreterContext(new_context);
448448
plans.emplace_back(std::move(plan));

src/Processors/QueryPlan/ReadFromRemote.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ class ReadFromRemote final : public ISourceStep
4242

4343
void enableMemoryBoundMerging();
4444
void enforceAggregationInOrder();
45-
void setRemoteFunction(bool is_remote_function_ = true) { is_remote_function = is_remote_function_; }
45+
void setIsRemoteFunction(bool is_remote_function_ = true) { is_remote_function = is_remote_function_; }
4646

4747
private:
4848
ClusterProxy::SelectStreamFactory::Shards shards;

tests/integration/test_storage_iceberg/test.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,14 @@ def add_df(mode):
676676
)
677677
assert len(cluster_secondary_queries) == 1
678678

679+
select_remote_cluster = (
680+
instance.query(f"SELECT * FROM remote('node2',{table_function_expr_cluster})")
681+
.strip()
682+
.split()
683+
)
684+
assert len(select_remote_cluster) == 600
685+
assert select_remote_cluster == select_regular
686+
679687

680688
@pytest.mark.parametrize("format_version", ["1", "2"])
681689
@pytest.mark.parametrize("storage_type", ["s3", "azure", "hdfs", "local"])

0 commit comments

Comments
 (0)