Skip to content

Conversation

@fuweid
Copy link
Contributor

@fuweid fuweid commented Feb 13, 2019

According to runc CVE issue, need to run test cases again.

@fuweid fuweid requested a review from Ace-Tang February 13, 2019 08:39
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #2709 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2709     +/-   ##
=========================================
- Coverage   69.35%   69.26%   -0.1%     
=========================================
  Files         278      278             
  Lines       17462    17462             
=========================================
- Hits        12111    12095     -16     
- Misses       4023     4036     +13     
- Partials     1328     1331      +3
Flag Coverage Δ
#criv1alpha2_test 39.56% <ø> (-0.07%) ⬇️
#integration_test_0 36.32% <ø> (-0.05%) ⬇️
#integration_test_1 35.26% <ø> (ø) ⬆️
#integration_test_2 36.29% <ø> (+0.01%) ⬆️
#integration_test_3 35.17% <ø> (ø) ⬆️
#node_e2e_test 34.97% <ø> (-0.07%) ⬇️
#unittest 27.39% <ø> (ø) ⬆️
Impacted Files Coverage Δ
cri/ocicni/cni_manager.go 58.82% <0%> (-11.77%) ⬇️
ctrd/image.go 67.31% <0%> (-1.95%) ⬇️
daemon/mgr/container.go 59.5% <0%> (-0.42%) ⬇️
cri/v1alpha2/cri.go 71.53% <0%> (-0.39%) ⬇️
ctrd/container.go 57.27% <0%> (-0.39%) ⬇️
daemon/mgr/container_utils.go 85.11% <0%> (+1.19%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @fuweid
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@fuweid
Copy link
Contributor Author

fuweid commented Feb 14, 2019

@Ace-Tang and @allencloud

The 1.2.0 works for the new runC version with updating the case. I will update the case later.

This PR is used to verify the runC version, no need to merge. Close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants