bugfix: make pouchd support top a paused container#2606
Merged
allencloud merged 1 commit intoDec 25, 2018
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2606 +/- ##
===========================================
- Coverage 69.38% 26.78% -42.61%
===========================================
Files 279 229 -50
Lines 18825 16933 -1892
===========================================
- Hits 13062 4535 -8527
- Misses 4287 12089 +7802
+ Partials 1476 309 -1167
|
allencloud
force-pushed
the
top-pausedcon
branch
from
9a49188 to
fc4ec10
Compare
Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
allencloud
force-pushed
the
top-pausedcon
branch
from
fc4ec10 to
d4e79b4
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com
Ⅰ. Describe what this PR did
Currently in pouchd, it does not support top a paused container, this pull request tries to make it.
Update the container status checking and test cases.
Ⅱ. Does this pull request fix one issue?
fixes #2598
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
added
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
cc @drpmma