From daa50cf714f355edaadaadcdebeb8c90c1c99d8b Mon Sep 17 00:00:00 2001 From: xiechengsheng Date: Fri, 20 Jul 2018 00:00:54 +0800 Subject: [PATCH] bugfix: pouch pull should handle space input as an error Signed-off-by: xiechengsheng --- cli/pull.go | 6 +++++- pkg/reference/parse_test.go | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/cli/pull.go b/cli/pull.go index 2b0ae860c..0523eb623 100644 --- a/cli/pull.go +++ b/cli/pull.go @@ -204,7 +204,11 @@ func pullMissingImage(ctx context.Context, apiClient client.CommonAPIClient, ima } } - namedRef, _ := reference.Parse(image) + namedRef, err := reference.Parse(image) + if err != nil { + return err + } + namedRef = reference.TrimTagForDigest(reference.WithDefaultTagIfMissing(namedRef)) var name, tag string diff --git a/pkg/reference/parse_test.go b/pkg/reference/parse_test.go index 40f03c2de..007790239 100644 --- a/pkg/reference/parse_test.go +++ b/pkg/reference/parse_test.go @@ -126,6 +126,11 @@ func TestParse(t *testing.T) { tag: "1669a6aa7350e1cdd28f972ddad5aceba2912f589f19a090ac", }, err: nil, + }, { + name: "Contains space input", + input: " ", + expected: nil, + err: ErrInvalid, }, } { ref, err := Parse(tc.input)