Merge pull request #1808 from cyrann/erhuan-branch

test: add unit-test for daemon/config/getUnknownFlags

Author: allencloud

daemon/config/config_test.go

@@ -3,6 +3,7 @@ package config
 import (
 	"testing"
 
+	"github.com/spf13/pflag"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -53,5 +54,44 @@ func TestGetConflictConfigurations(t *testing.T) {
 }
 
 func TestGetUnknownFlags(t *testing.T) {
-	// TODO
+
+	flagSet := new(pflag.FlagSet)
+	flagSet.String("a", "a", "a")
+	flagSet.Bool("b", false, "b")
+	flagSet.Int("c", -500, "c")
+
+	flagSetNil := new(pflag.FlagSet)
+
+	assert := assert.New(t)
+
+	fileFlagsKnown := map[string]interface{}{
+		"a": "a",
+		"b": true,
+	}
+
+	fileFlagsUnknown := map[string]interface{}{
+		"c": 100,
+		"d": "d",
+	}
+
+	fileFlagsNil := map[string]interface{}{}
+
+	error := getUnknownFlags(flagSet, fileFlagsKnown)
+	assert.Equal(error, nil)
+
+	error = getUnknownFlags(flagSet, fileFlagsUnknown)
+	assert.NotNil(error)
+
+	error = getUnknownFlags(flagSet, fileFlagsNil)
+	assert.Equal(error, nil)
+
+	error = getUnknownFlags(flagSetNil, fileFlagsUnknown)
+	assert.NotNil(error)
+
+	error = getUnknownFlags(flagSetNil, fileFlagsKnown)
+	assert.NotNil(error)
+
+	error = getUnknownFlags(flagSetNil, fileFlagsNil)
+	assert.Equal(error, nil)
+
 }