test: add tests for label and config file in daemon

Signed-off-by: letty <[email protected]>

Author: Letty5411

test/util_daemon.go

@@ -1,6 +1,9 @@
 package main
 
 import (
+	"encoding/json"
+	"fmt"
+	"os"
 	"strings"
 
 	"github.com/alibaba/pouch/test/command"
@@ -60,3 +63,26 @@ func RunWithSpecifiedDaemon(d *daemon.Config, cmd ...string) *icmd.Result {
 	args := append(append([]string{"--host"}, sock), cmd...)
 	return command.PouchRun(args...)
 }
+
+// CreateConfigFile create configuration file and marshal cfg.
+func CreateConfigFile(path string, cfg interface{}) error {
+	idx := strings.LastIndex(path, "/")
+	if _, err := os.Stat(path[0:idx]); os.IsNotExist(err) {
+		os.Mkdir(path[0:idx], os.ModePerm)
+	}
+
+	file, err := os.Create(path)
+	if err != nil {
+		return err
+	}
+
+	s, err := json.Marshal(cfg)
+	if err != nil {
+		return err
+	}
+	fmt.Fprintf(file, "%s", s)
+	file.Sync()
+
+	defer file.Close()
+	return nil
+}

test/z_cli_daemon_test.go

@@ -3,12 +3,16 @@ package main
 import (
 	"encoding/json"
 	"fmt"
+	"os"
+	"strings"
 
 	"github.com/alibaba/pouch/apis/types"
+	"github.com/alibaba/pouch/daemon/config"
 	"github.com/alibaba/pouch/test/command"
 	"github.com/alibaba/pouch/test/daemon"
 	"github.com/alibaba/pouch/test/environment"
 
+	"github.com/alibaba/pouch/test/util"
 	"github.com/go-check/check"
 	"github.com/gotestyourself/gotestyourself/icmd"
 )
@@ -89,9 +93,89 @@ func (suite *PouchDaemonSuite) TestDaemonListenTCP(c *check.C) {
 	}
 }
 
-// TestDaemonConfigFile tests start daemon with configfile works.
+// TestDaemonConfigFile tests start daemon with configure file works.
 func (suite *PouchDaemonSuite) TestDaemonConfigFile(c *check.C) {
-	// TODO
+	configFile := "/tmp/pouch.json"
+	file, err := os.Create(configFile)
+	c.Assert(err, check.IsNil)
+	defer file.Close()
+	defer os.Remove(configFile)
+
+	// Unmarshal config.Config, all fields in this struct could be handled in configuration file.
+	cfg := config.Config{
+		Debug: true,
+	}
+	s, _ := json.Marshal(cfg)
+	fmt.Fprintf(file, "%s", s)
+	file.Sync()
+
+	// TODO: uncomment this when issue #1003 is fixed.
+	//dcfg, err := StartDefaultDaemonDebug("--config-file="+configFile)
+	//{
+	//	err := dcfg.StartDaemon()
+	//	c.Assert(err, check.IsNil)
+	//}
+	//
+	//// TODO: verify more
+	//
+	//// Must kill it, as we may loose the pid in next call.
+	//defer dcfg.KillDaemon()
+
+	// config file cowork with parameter, no confilct
+}
+
+// TestDaemonConfigFileConfilct tests start daemon with configure file confilicts with parameter.
+func (suite *PouchDaemonSuite) TestDaemonConfigFileConfilct(c *check.C) {
+	path := "/tmp/pouch.json"
+	cfg := struct {
+		Debug bool `json:"debug,omitempty"`
+	}{
+		Debug: false,
+	}
+	CreateConfigFile(path, cfg)
+	defer os.Remove(path)
+
+	_, err := StartDefaultDaemon("--debug", "--config-file="+path)
+	c.Assert(err, check.NotNil)
+	util.PartialEqual(fmt.Sprintf("%s", err), "conflict")
+}
+
+// TestDaemonConfigFileUnknownFlag tests start daemon with unknow flags in configure file.
+func (suite *PouchDaemonSuite) TestDaemonConfigFileUnknownFlag(c *check.C) {
+	path := "/tmp/pouch.json"
+	cfg := struct {
+		Adsj bool `json:"adsj,omitempty"`
+	}{
+		Adsj: false,
+	}
+	CreateConfigFile(path, cfg)
+	defer os.Remove(path)
+
+	_, err := StartDefaultDaemon("--debug", "--config-file="+path)
+	c.Assert(err, check.NotNil)
+	util.PartialEqual(fmt.Sprintf("%s", err), "unknow")
+}
+
+// TestDaemonConfigFileAndCli tests start daemon with configure file and CLI .
+func (suite *PouchDaemonSuite) TestDaemonConfigFileAndCli(c *check.C) {
+	// Check default configure file could work
+	path := "/etc/pouch/config.json"
+	cfg := struct {
+		Labels []string `json:"labels,omitempty"`
+	}{
+		Labels: []string{"a=b"},
+	}
+	CreateConfigFile(path, cfg)
+	defer os.Remove(path)
+
+	// Do Not specify configure file explicitly, it should work.
+	dcfg, err := StartDefaultDaemon()
+	c.Assert(err, check.IsNil)
+	defer dcfg.KillDaemon()
+
+	result := RunWithSpecifiedDaemon(dcfg, "info")
+	err = util.PartialEqual(result.Stdout(), "a=b")
+	c.Assert(err, check.IsNil)
 }
 
 // TestDaemonInvalideArgs tests invalid args in deamon return error
@@ -142,3 +226,42 @@ func (suite *PouchDaemonSuite) TestDaemonRestart(c *check.C) {
 	}
 	c.Assert(string(result.State.Status), check.Equals, "running")
 }
+
+// TestDaemonLabel tests start daemon with label works.
+func (suite *PouchDaemonSuite) TestDaemonLabel(c *check.C) {
+	dcfg, err := StartDefaultDaemonDebug("--label a=b")
+	// Start a test daemon with test args.
+	if err != nil {
+		c.Skip("deamon start failed.")
+	}
+	// Must kill it, as we may loose the pid in next call.
+	defer dcfg.KillDaemon()
+
+	result := RunWithSpecifiedDaemon(dcfg, "info")
+	err = util.PartialEqual(result.Stdout(), "a=b")
+	c.Assert(err, check.IsNil)
+}
+
+// TestDaemonLabelDup tests start daemon with duplicated label works.
+func (suite *PouchDaemonSuite) TestDaemonLabelDup(c *check.C) {
+	dcfg, err := StartDefaultDaemonDebug("--label a=b --label a=b")
+	// Start a test daemon with test args.
+	if err != nil {
+		c.Skip("deamon start failed.")
+	}
+	// Must kill it, as we may loose the pid in next call.
+	defer dcfg.KillDaemon()
+
+	result := RunWithSpecifiedDaemon(dcfg, "info")
+	err = util.PartialEqual(result.Stdout(), "a=b")
+	c.Assert(err, check.IsNil)
+
+	cnt := strings.Count(result.Stdout(), "a=b")
+	c.Assert(cnt, check.Equals, 1)
+}
+
+// TestDaemonLabelNeg tests start daemon with wrong label could not work.
+func (suite *PouchDaemonSuite) TestDaemonLabelNeg(c *check.C) {
+	_, err := StartDefaultDaemon("--label adsf")
+	c.Assert(err, check.NotNil)
+}