Skip to content

Commit 92de646

Browse files
committed
roolback the code about CRI of version v1alpha1
Signed-off-by: Starnop <[email protected]>
1 parent 2f0b5cf commit 92de646

File tree

18 files changed

+2233
-4149
lines changed

18 files changed

+2233
-4149
lines changed

cri/apis/v1alpha1/api.proto

Lines changed: 0 additions & 1209 deletions
This file was deleted.

cri/v1alpha1/cri.go

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313

1414
apitypes "github.com/alibaba/pouch/apis/types"
1515
anno "github.com/alibaba/pouch/cri/annotations"
16-
runtime "github.com/alibaba/pouch/cri/apis/v1alpha1"
1716
"github.com/alibaba/pouch/daemon/config"
1817
"github.com/alibaba/pouch/daemon/mgr"
1918
"github.com/alibaba/pouch/pkg/errtypes"
@@ -25,6 +24,7 @@ import (
2524
// NOTE: "golang.org/x/net/context" is compatible with standard "context" in golang1.7+.
2625
"github.com/cri-o/ocicni/pkg/ocicni"
2726
"github.com/sirupsen/logrus"
27+
"k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime"
2828
)
2929

3030
const (
@@ -497,7 +497,6 @@ func (c *CriManager) CreateContainer(ctx context.Context, r *runtime.CreateConta
497497
specAnnotation[anno.ContainerType] = anno.ContainerTypeContainer
498498
specAnnotation[anno.SandboxName] = podSandboxID
499499

500-
resources := r.GetConfig().GetLinux().GetResources()
501500
createConfig := &apitypes.ContainerCreateConfig{
502501
ContainerConfig: apitypes.ContainerConfig{
503502
Entrypoint: config.Command,
@@ -511,12 +510,9 @@ func (c *CriManager) CreateContainer(ctx context.Context, r *runtime.CreateConta
511510
StdinOnce: config.StdinOnce,
512511
Tty: config.Tty,
513512
SpecAnnotation: specAnnotation,
514-
NetPriority: config.NetPriority,
515-
DiskQuota: resources.GetDiskQuota(),
516513
},
517514
HostConfig: &apitypes.HostConfig{
518-
Binds: generateMountBindings(config.GetMounts()),
519-
Resources: parseResourcesFromCRI(resources),
515+
Binds: generateMountBindings(config.GetMounts()),
520516
},
521517
NetworkingConfig: &apitypes.NetworkingConfig{},
522518
}
@@ -717,8 +713,6 @@ func (c *CriManager) ContainerStatus(ctx context.Context, r *runtime.ContainerSt
717713
imageRef = imageInfo.RepoDigests[0]
718714
}
719715

720-
resources := container.HostConfig.Resources
721-
diskQuota := container.Config.DiskQuota
722716
status := &runtime.ContainerStatus{
723717
Id: container.ID,
724718
Metadata: metadata,
@@ -735,8 +729,6 @@ func (c *CriManager) ContainerStatus(ctx context.Context, r *runtime.ContainerSt
735729
Labels: labels,
736730
Annotations: annotations,
737731
// TODO: LogPath.
738-
Volumes: parseVolumesFromPouch(container.Config.Volumes),
739-
Resources: parseResourcesFromPouch(resources, diskQuota),
740732
}
741733

742734
return &runtime.ContainerStatusResponse{Status: status}, nil
@@ -803,7 +795,6 @@ func (c *CriManager) UpdateContainerResources(ctx context.Context, r *runtime.Up
803795
resources := r.GetLinux()
804796
updateConfig := &apitypes.UpdateConfig{
805797
Resources: parseResourcesFromCRI(resources),
806-
DiskQuota: resources.GetDiskQuota(),
807798
}
808799
err = c.ContainerMgr.Update(ctx, containerID, updateConfig)
809800
if err != nil {

cri/v1alpha1/cri_network.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ import (
55
"os"
66
"strings"
77

8-
runtime "github.com/alibaba/pouch/cri/apis/v1alpha1"
98
"github.com/alibaba/pouch/cri/config"
109

1110
"github.com/cri-o/ocicni/pkg/ocicni"
1211
"github.com/sirupsen/logrus"
12+
"k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime"
1313
)
1414

1515
// CniMgr as an interface defines all operations against CNI.

cri/v1alpha1/cri_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package v1alpha1
22

33
import (
4-
runtime "github.com/alibaba/pouch/cri/apis/v1alpha1"
4+
"k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime"
55
)
66

77
// SandboxMeta represents the sandbox's meta data.

cri/v1alpha1/cri_utils.go

Lines changed: 7 additions & 128 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515

1616
apitypes "github.com/alibaba/pouch/apis/types"
1717
anno "github.com/alibaba/pouch/cri/annotations"
18-
runtime "github.com/alibaba/pouch/cri/apis/v1alpha1"
1918
"github.com/alibaba/pouch/daemon/mgr"
2019
"github.com/alibaba/pouch/pkg/utils"
2120

@@ -25,6 +24,7 @@ import (
2524
"github.com/go-openapi/strfmt"
2625
"golang.org/x/net/context"
2726
"golang.org/x/sys/unix"
27+
"k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime"
2828
)
2929

3030
const uuidDir = "/dev/disk/by-uuid"
@@ -771,7 +771,6 @@ func imageToCriImage(image *apitypes.ImageInfo) (*runtime.Image, error) {
771771
Size_: size,
772772
Uid: uid,
773773
Username: username,
774-
Volumes: parseVolumesFromPouch(image.Config.Volumes),
775774
}, nil
776775
}
777776

@@ -946,132 +945,12 @@ func blkrdev(device string) (uint64, error) {
946945

947946
// parseResourceFromCRI parse Resources from runtime.LinuxContainerResources to apitypes.Resources
948947
func parseResourcesFromCRI(runtimeResources *runtime.LinuxContainerResources) apitypes.Resources {
949-
var memorySwappiness *int64
950-
if runtimeResources.GetMemorySwappiness() != nil {
951-
memorySwappiness = &runtimeResources.GetMemorySwappiness().Value
952-
}
953-
954948
return apitypes.Resources{
955-
CPUPeriod: runtimeResources.GetCpuPeriod(),
956-
CPUQuota: runtimeResources.GetCpuQuota(),
957-
CPUShares: runtimeResources.GetCpuShares(),
958-
Memory: runtimeResources.GetMemoryLimitInBytes(),
959-
CpusetCpus: runtimeResources.GetCpusetCpus(),
960-
CpusetMems: runtimeResources.GetCpusetMems(),
961-
BlkioWeight: uint16(runtimeResources.GetBlkioWeight()),
962-
BlkioWeightDevice: parseWeightDeviceFromCRI(runtimeResources.GetBlkioWeightDevice()),
963-
BlkioDeviceReadBps: parseThrottleDeviceFromCRI(runtimeResources.GetBlkioDeviceReadBps()),
964-
BlkioDeviceWriteBps: parseThrottleDeviceFromCRI(runtimeResources.GetBlkioDeviceWriteBps()),
965-
BlkioDeviceReadIOps: parseThrottleDeviceFromCRI(runtimeResources.GetBlkioDeviceRead_IOps()),
966-
BlkioDeviceWriteIOps: parseThrottleDeviceFromCRI(runtimeResources.GetBlkioDeviceWrite_IOps()),
967-
KernelMemory: runtimeResources.GetKernelMemory(),
968-
MemoryReservation: runtimeResources.GetMemoryReservation(),
969-
MemorySwappiness: memorySwappiness,
970-
Ulimits: parseUlimitFromCRI(runtimeResources.GetUlimits()),
971-
}
972-
}
973-
974-
// parseResourceFromPouch parse Resources from apitypes.Resources to runtime.LinuxContainerResources
975-
func parseResourcesFromPouch(apitypesResources apitypes.Resources, diskQuota map[string]string) *runtime.LinuxContainerResources {
976-
var memorySwappiness *runtime.Int64Value
977-
if apitypesResources.MemorySwappiness != nil {
978-
memorySwappiness = &runtime.Int64Value{Value: *apitypesResources.MemorySwappiness}
979-
}
980-
981-
return &runtime.LinuxContainerResources{
982-
CpuPeriod: apitypesResources.CPUPeriod,
983-
CpuQuota: apitypesResources.CPUQuota,
984-
CpuShares: apitypesResources.CPUShares,
985-
MemoryLimitInBytes: apitypesResources.Memory,
986-
CpusetCpus: apitypesResources.CpusetCpus,
987-
CpusetMems: apitypesResources.CpusetMems,
988-
BlkioWeight: uint32(apitypesResources.BlkioWeight),
989-
BlkioWeightDevice: parseWeightDeviceFromPouch(apitypesResources.BlkioWeightDevice),
990-
BlkioDeviceReadBps: parseThrottleDeviceFromPouch(apitypesResources.BlkioDeviceReadBps),
991-
BlkioDeviceWriteBps: parseThrottleDeviceFromPouch(apitypesResources.BlkioDeviceWriteBps),
992-
BlkioDeviceRead_IOps: parseThrottleDeviceFromPouch(apitypesResources.BlkioDeviceReadIOps),
993-
BlkioDeviceWrite_IOps: parseThrottleDeviceFromPouch(apitypesResources.BlkioDeviceWriteIOps),
994-
KernelMemory: apitypesResources.KernelMemory,
995-
MemoryReservation: apitypesResources.MemoryReservation,
996-
MemorySwappiness: memorySwappiness,
997-
Ulimits: parseUlimitFromPouch(apitypesResources.Ulimits),
998-
DiskQuota: diskQuota,
999-
}
1000-
}
1001-
1002-
// parseWeightDeviceFromCRI parse WeightDevice from runtime.WeightDevice to apitypes.WeightDevice
1003-
func parseWeightDeviceFromCRI(runtimeWeightDevices []*runtime.WeightDevice) (weightDevices []*apitypes.WeightDevice) {
1004-
for _, v := range runtimeWeightDevices {
1005-
weightDevices = append(weightDevices, &apitypes.WeightDevice{
1006-
Path: v.GetPath(),
1007-
Weight: uint16(v.GetWeight()),
1008-
})
1009-
}
1010-
return
1011-
}
1012-
1013-
// parseWeightDeviceFromPouch parse WeightDevice from apitypes.WeightDevice to runtime.WeightDevice
1014-
func parseWeightDeviceFromPouch(apitypesWeightDevices []*apitypes.WeightDevice) (weightDevices []*runtime.WeightDevice) {
1015-
for _, v := range apitypesWeightDevices {
1016-
weightDevices = append(weightDevices, &runtime.WeightDevice{
1017-
Path: v.Path,
1018-
Weight: uint32(v.Weight),
1019-
})
1020-
}
1021-
return
1022-
}
1023-
1024-
// parseThrottleDeviceFromCRI parse ThrottleDevice from runtime.ThrottleDevice to apitypes.ThrottleDevice
1025-
func parseThrottleDeviceFromCRI(runtimeThrottleDevices []*runtime.ThrottleDevice) (throttleDevices []*apitypes.ThrottleDevice) {
1026-
for _, v := range runtimeThrottleDevices {
1027-
throttleDevices = append(throttleDevices, &apitypes.ThrottleDevice{
1028-
Path: v.GetPath(),
1029-
Rate: v.GetRate(),
1030-
})
1031-
}
1032-
return
1033-
}
1034-
1035-
// parseThrottleDeviceFromPouch parse ThrottleDevice from apitypes.ThrottleDevice to runtime.ThrottleDevice
1036-
func parseThrottleDeviceFromPouch(apitypesThrottleDevices []*apitypes.ThrottleDevice) (throttleDevices []*runtime.ThrottleDevice) {
1037-
for _, v := range apitypesThrottleDevices {
1038-
throttleDevices = append(throttleDevices, &runtime.ThrottleDevice{
1039-
Path: v.Path,
1040-
Rate: v.Rate,
1041-
})
1042-
}
1043-
return
1044-
}
1045-
1046-
// parseUlimitFromCRI parse Ulimit from runtime.Ulimit to apitypes.Ulimit
1047-
func parseUlimitFromCRI(runtimeUlimits []*runtime.Ulimit) (ulimits []*apitypes.Ulimit) {
1048-
for _, v := range runtimeUlimits {
1049-
ulimits = append(ulimits, &apitypes.Ulimit{
1050-
Hard: v.GetHard(),
1051-
Name: v.GetName(),
1052-
Soft: v.GetSoft(),
1053-
})
1054-
}
1055-
return
1056-
}
1057-
1058-
// parseUlimitFromPouch parse Ulimit from apitypes.Ulimit to runtime.Ulimit
1059-
func parseUlimitFromPouch(apitypesUlimits []*apitypes.Ulimit) (ulimits []*runtime.Ulimit) {
1060-
for _, v := range apitypesUlimits {
1061-
ulimits = append(ulimits, &runtime.Ulimit{
1062-
Hard: v.Hard,
1063-
Name: v.Name,
1064-
Soft: v.Soft,
1065-
})
1066-
}
1067-
return
1068-
}
1069-
1070-
// parseVolumesFromPouch parse Volumes from map[string]interface{} to map[string]*runtime.Volume
1071-
func parseVolumesFromPouch(containerVolumes map[string]interface{}) map[string]*runtime.Volume {
1072-
volumes := make(map[string]*runtime.Volume)
1073-
for k := range containerVolumes {
1074-
volumes[k] = &runtime.Volume{}
949+
CPUPeriod: runtimeResources.GetCpuPeriod(),
950+
CPUQuota: runtimeResources.GetCpuQuota(),
951+
CPUShares: runtimeResources.GetCpuShares(),
952+
Memory: runtimeResources.GetMemoryLimitInBytes(),
953+
CpusetCpus: runtimeResources.GetCpusetCpus(),
954+
CpusetMems: runtimeResources.GetCpusetMems(),
1075955
}
1076-
return volumes
1077956
}

0 commit comments

Comments
 (0)