Skip to content

Commit 6f8317a

Browse files
committed
add unit-test for daemon/config/getUnknownFlags
Signed-off-by: Erhuan <[email protected]>
1 parent 2f0b5cf commit 6f8317a

File tree

1 file changed

+42
-1
lines changed

1 file changed

+42
-1
lines changed

daemon/config/config_test.go

Lines changed: 42 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package config
33
import (
44
"testing"
55

6+
"github.com/spf13/pflag"
67
"github.com/stretchr/testify/assert"
78
)
89

@@ -53,5 +54,45 @@ func TestGetConflictConfigurations(t *testing.T) {
5354
}
5455

5556
func TestGetUnknownFlags(t *testing.T) {
56-
// TODO
57+
var cfg = &Config{}
58+
59+
flagSet := new(pflag.FlagSet)
60+
flagSet.StringVar(&cfg.HomeDir, "home-dir", "/test/test/test", "Specify root dir of pouchd")
61+
flagSet.BoolVar(&cfg.IsCriEnabled, "enable-cri", false, "Specify whether enable the cri part of pouchd which is used to support Kubernetes")
62+
flagSet.IntVar(&cfg.OOMScoreAdjust, "oom-score-adj", -500, "Set the oom_score_adj for the daemon")
63+
64+
flagSetNil := new(pflag.FlagSet)
65+
66+
assert := assert.New(t)
67+
68+
fileFlagsKnown := map[string]interface{}{
69+
"home-dir": "go/go/go",
70+
"enable-cri": true,
71+
}
72+
73+
fileFlagsUnknown := map[string]interface{}{
74+
"oom-score-adj": 100,
75+
"unknownflag": "unknownflag",
76+
}
77+
78+
fileFlagsNil := map[string]interface{}{}
79+
80+
error := getUnknownFlags(flagSet, fileFlagsKnown)
81+
assert.Equal(error, nil)
82+
83+
error = getUnknownFlags(flagSet, fileFlagsUnknown)
84+
assert.NotNil(error)
85+
86+
error = getUnknownFlags(flagSet, fileFlagsNil)
87+
assert.Equal(error, nil)
88+
89+
error = getUnknownFlags(flagSetNil, fileFlagsUnknown)
90+
assert.NotNil(error)
91+
92+
error = getUnknownFlags(flagSetNil, fileFlagsKnown)
93+
assert.NotNil(error)
94+
95+
error = getUnknownFlags(flagSetNil, fileFlagsNil)
96+
assert.Equal(error, nil)
97+
5798
}

0 commit comments

Comments
 (0)