Skip to content

Conversation

@mmacai
Copy link
Collaborator

@mmacai mmacai commented Apr 30, 2021

Description

  • fixed some npm audit reports
  • updated channels example to use kafkajs
  • updated channels example and smoke tests to use node 14

What to look out for

  • all cypress tests should pass

Process

The goal is to improve not only the code in this PR but also our skills! The "rules":

  • The review is considered "done" as soon as all reviewers have added their review, and all their comments have been addressed.
  • For knowledge-sharing reviews, each reviewer should "approve" the PR after studying its content.
  • After the approval, the merge is concluded by the developer.

Have fun!

@mmacai mmacai requested a review from kevinbader April 30, 2021 07:52
Copy link
Contributor

@kevinbader kevinbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmacai mmacai merged commit ae84687 into master May 3, 2021
@mmacai mmacai deleted the audit-fixes branch May 3, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants