Refine the sql to query non empty repositories (goharbor#22269)

stonezdj · AYDEV-FR · commit 149285764743 · 2025-09-19T22:05:36.000+02:00
use exists instead of in condition

Signed-off-by: stonezdj &lt;stone.zhang@broadcom.com&gt;
diff --git a/src/pkg/repository/dao/dao.go b/src/pkg/repository/dao/dao.go
@@ -159,7 +159,7 @@ func (d *dao) NonEmptyRepos(ctx context.Context) ([]*model.RepoRecord, error) {
 		return nil, err
 	}
 
-	sql := `select * from repository where repository_id in (select distinct repository_id from tag)`
+	sql := `select * from repository where exists (select 1 from tag where tag.repository_id = repository.repository_id)`
 	_, err = ormer.Raw(sql).QueryRows(&repos)
 	if err != nil {
 		return repos, err

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ func (d dao) NonEmptyRepos(ctx context.Context) ([]model.RepoRecord, error) {`
`159`	`159`	`return nil, err`
`160`	`160`	`}`
`161`	`161`
`162`		- sql := `select * from repository where repository_id in (select distinct repository_id from tag)`
	`162`	+ sql := `select * from repository where exists (select 1 from tag where tag.repository_id = repository.repository_id)`
`163`	`163`	`_, err = ormer.Raw(sql).QueryRows(&repos)`
`164`	`164`	`if err != nil {`
`165`	`165`	`return repos, err`