Skip to content
This repository was archived by the owner on Oct 5, 2018. It is now read-only.

Commit 78f464d

Browse files
diandersldts
authored andcommitted
mmc: dw_mmc: Consider HLE errors to be data and command errors
The dw_mmc driver enables HLE errors as part of DW_MCI_ERROR_FLAGS but nothing in the interrupt handler actually handles them and ACKs them. That means that if we ever get an HLE error we'll just keep getting interrupts and we'll wedge things. We really don't expect HLE errors but if we ever get them we shouldn't silently ignore them. Note that I have seen HLE errors while constantly ejecting and inserting cards (ejecting while inserting, etc). Signed-off-by: Doug Anderson <[email protected]> Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
1 parent 0ed0104 commit 78f464d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/mmc/host/dw_mmc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@
4444
/* Common flag combinations */
4545
#define DW_MCI_DATA_ERROR_FLAGS (SDMMC_INT_DRTO | SDMMC_INT_DCRC | \
4646
SDMMC_INT_HTO | SDMMC_INT_SBE | \
47-
SDMMC_INT_EBE)
47+
SDMMC_INT_EBE | SDMMC_INT_HLE)
4848
#define DW_MCI_CMD_ERROR_FLAGS (SDMMC_INT_RTO | SDMMC_INT_RCRC | \
49-
SDMMC_INT_RESP_ERR)
49+
SDMMC_INT_RESP_ERR | SDMMC_INT_HLE)
5050
#define DW_MCI_ERROR_FLAGS (DW_MCI_DATA_ERROR_FLAGS | \
51-
DW_MCI_CMD_ERROR_FLAGS | SDMMC_INT_HLE)
51+
DW_MCI_CMD_ERROR_FLAGS)
5252
#define DW_MCI_SEND_STATUS 1
5353
#define DW_MCI_RECV_STATUS 2
5454
#define DW_MCI_DMA_THRESHOLD 16

0 commit comments

Comments
 (0)