fix: don't flush on debounced state updates #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franky47
added
the
feature/time-safety
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This simulates the behaviour of other adapters, and exposes the problem: uncleared pending updates would cause a URL update to be emitted when flushing the global throttle queue. They would be cleared on the next push by a throttled update, but not by a debounced update (until its timeout expires).
|
🎉 This PR is included in version 2.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I-3B
pushed a commit
to I-3B/nuqs
that referenced
this pull request
Oct 25, 2025
aryasaatvik
pushed a commit
to aryasaatvik/nuqs
that referenced
this pull request
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the state updater function with
{ shallow: false, limitUrlUpdates: debounce(...) }, it would trigger a flush of the throttle queue to obtain the pending Promise to return, which caused unnecessary URL update calls to be made to the server.We can obtain the pending Promise independently instead and avoid those flushes.
Tasks