fix: Maintain location.state in React Router frameworks#840
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
franky47
force-pushed
the
fix/839-react-router-state
branch
from
3ff4dcf to
1e72e95
Compare
|
🎉 This PR is included in version 2.3.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
shallow: false, any user state set usingnavigate('url', { state: whatever })was reset to null.Kind of a hack to read it from
history.state.usr, but it seems to work without adding auseLocationdependency (which might cause loss of referential stability for the state updater function and possibly extra renders). However, this will limit it to the BrowserRouter, and not be compatible with the in-memory router (which wasn't compatible before anyway, and is unlikely to ever be).Closes #839.