Conversation
|
@neefrehman is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
neefrehman
commented
Jul 6, 2025
neefrehman
changed the title
Member
|
I had read about that const modifier in generics when it came out but it didn't occur to me to use it here, thanks for the suggestion, it's a nice improvement! |
franky47
approved these changes
Jul 6, 2025
neefrehman
changed the title
neefrehman
changed the title
const modifier to literal parsers to infer their arguments as literals
neefrehman
changed the title
const modifier to literal parsers to infer their arguments as literalsconst modifier to literal parsers to auto-infer their arguments as literals
franky47
added
the
deploy:preview
commit: |
|
🎉 This PR is included in version 2.5.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often have to add the
as constmodifier to arrays of strings or numbers to get the types to work properly, as is also suggested by the docs. I thought it was worth opening this PR that adds a const modifier to the type parameters for the literals, so that it can automatically do this. I've also updated a handful of examples and docs to illustrate the simpler usage.Hopefully the you agree that it's a nice type enhancement @franky47, but feel free to close this PR if not :)