This repository was archived by the owner on Dec 19, 2023. It is now read-only.
[Fix] e-mail verification bypass #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📊 Metadata *
Bounty URL: https://www.huntr.dev/bounties/3-packagist-userfrosting%2Fuserfrosting
⚙️ Description *
UserFrosting is following strict email verification but can be bypassed by changing email in account settings.
Bypass is fixed by requiring verification before updating to new email.
💻 Technical Description *
Existent verification mecanism was extended to handle email address change. If mail-verification is enabled in settings, acount settings update will store newEmail as a request and send an email with link for verification, after link is open by new email owner settings will be updated to new email.
🐛 Proof of Concept (PoC) *
5 Change the email and save
🔥 Proof of Fix (PoF) *
After fix verification email is sent to requested address and account information won't be updated untill verification is completed:
To verify follow received link:

After verification new email can be used, account information is updated:

👍 User Acceptance Testing (UAT)
e-mail can be updated using verification and application works normally