Add write-only password to item resource #229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a write-only password feature to the `onepassword_item` resource. This allows for setting a password that is not stored in the Terraform state, which is useful for ephemeral values. The following new attributes have been added: - `password_wo`: A write-only password. - `password_wo_version`: An integer that must be incremented to trigger an update to the `password_wo` field. This commit also includes: - Updates to various Go dependencies, including the Terraform plugin framework so that `schema.StringAttribute.WriteOnly` can be used. - New acceptance tests for the write-only password functionality.
# Conflicts: # go.mod # go.sum # internal/provider/const.go # internal/provider/onepassword_item_resource_test.go
Contributor
volodymyrZotov
left a comment
volodymyrZotov
left a comment
There was a problem hiding this comment.
@tbarthel-fr Thank you for the contribution!
I was able to review it and found that if using password_wo it still stored raw password in the plan.
To reproduce,
terraform plan -out=tfplanterraform show -json tfplan | jq(skip jq if you don ot have it)- Check printed plan and see that password still have a value.
Could you please take a look into that?
| MarkdownDescription: passwordWriteOnceDescription, | ||
| Optional: true, | ||
| Sensitive: true, | ||
| WriteOnly: true, |
Contributor
There was a problem hiding this comment.
WriteOnly property not exists here.
volodymyrZotov
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a write-only password feature to the
onepassword_itemresource. This allows for setting a password that is not stored in the Terraform state, which is useful for ephemeral values.The following new attributes have been added:
password_wo: A write-only password.password_wo_version: An integer that must be incremented to trigger an update to thepassword_wofield.This commit also includes:
schema.StringAttribute.WriteOnlycan be used.