Skip to content

fix(processor): validate expected_cycles after rounding (fixes #2741)#2746

Open
erenyegit wants to merge 1 commit into0xMiden:nextfrom
erenyegit:fix-expected-cycles-validation-after-rounding
Open

fix(processor): validate expected_cycles after rounding (fixes #2741)#2746
erenyegit wants to merge 1 commit into0xMiden:nextfrom
erenyegit:fix-expected-cycles-validation-after-rounding

Conversation

@erenyegit
Copy link

Made-with: Cursor

Describe your changes

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Commits are signed.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.
  • Updated `CHANGELOG.md'

Fixes #2741

@github-actions
Copy link

Automated check (CONTRIBUTING.md)

Findings:

Recommendations:

  • Consider adding a Test plan or clear review steps.

Next steps:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expected_cycles validation happens before rounding, should be after

1 participant