Open
Conversation
|
captainrandom
force-pushed
the
contract-whitelisted-borrowers
branch
from
0000916 to
e38d82d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It white lists borrows based on a list of addresses stored in a contract. This gets the abi from etherscan.
What is the current behavior? (You can also link to an open issue here)
I don't think that there is one? Currently there is a static allowed list, but I'd like to make the borrow white list to be dynamic whenever someone updates the contract (without the need to update the signal).
What is the new behavior (if this is a feature change)?
Gets the whitellisted borrower addresses from the smart contract and checks if the provided borrower address is in the set.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
It shouldn't.