-
Notifications
You must be signed in to change notification settings - Fork 478
Fix bugs in sqlite timeseries output and add IDF parsing capabilities within unit tests #4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 48 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
583f11c
Fix sqlite bugs and add more unit tests upstream
mbadams5 9f4f6fd
Fix unit test failures
mbadams5 7471a43
Merge branch 'develop' into sqlite_timeseries
mbadams5 50f2366
Fix windows newline issue (for real hopefully)
mbadams5 d1f5c03
Add more unit tests
mbadams5 43aa536
Merge branch 'develop' into sqlite_timeseries
mbadams5 60be015
Add more unit test
mbadams5 ced5959
Fix minor bug not related to sqlite
mbadams5 b6e1d2d
Add more unit tests
mbadams5 e4eedef
Add extra validation to DateToStringWithMonth
mbadams5 c7cfc17
Clean up to get tests to appear in CI
mbadams5 18797a4
Add more unit tests and clean up tests
mbadams5 c57daaa
Add more unit tests
mbadams5 e2654fa
Try to fix failing Windows unit test
mbadams5 92864c7
Work on more unit tests
mbadams5 e6a9cc5
Merge branch 'develop' into sqlite_timeseries
mbadams5 227ffe9
Add EnergyPlusFixture and OutputProcessorFixture
mbadams5 8dca04a
Clean up EnergyPlusFixture
mbadams5 49beb82
Add documentation, add compare cerr/cout
mbadams5 b18b8c1
Get rid of cerr output in DXCoil unit test
mbadams5 6c67ab9
Add InputProcessor unit tests
mbadams5 42e1bca
Try to fix failing unit tests and build failures
mbadams5 6701f54
Try to fix failing unit test again
mbadams5 7f06e89
Fix failing unit tests and add IDF parsing
mbadams5 4e46eff
Major clean up and fix bad unit tests
mbadams5 cc27226
Add new unit test
mbadams5 0dbaeac
Implement IDD cache, show message, clean up
mbadams5 8db0d03
Refactor names and remove unnecessary nullptr
mbadams5 acd4fd4
Add more unit tests, clean up code
mbadams5 69e41eb
Move ReportNumberCounter, fix build error
mbadams5 27adb17
Add more unit tests and failing unit test for bug fix
mbadams5 acab755
FINALLY fix original bugs
mbadams5 26aa73a
Clean up unit test
mbadams5 7c10c47
Fix unit test and linux warning
mbadams5 f308377
This is a major clean up and adds a custom parser
mbadams5 85710b9
Add clear_state(), move function static, clean up
mbadams5 905c8d4
Merge branch 'develop' into sqlite_timeseries
mbadams5 1397fa5
Add unit tests, fix unit failures, clean up code
mbadams5 f5127f3
Documentation and clean up
mbadams5 7d5dbf3
Merge branch 'develop' into sqlite_timeseries
mbadams5 2105e04
Major clean up and more documentation
mbadams5 cf3ab52
Add more clear_state() and refactor Humidifiers tests
mbadams5 0c67f9d
Refactor HeatBalanceManager tests
mbadams5 26c5ec0
Add more clear_state() and clean up
mbadams5 1ea3d1b
Refactor MixedAir unit test
mbadams5 6ee14d9
Fix compile errors
mbadams5 6cbad89
Fix failing windows unit test
mbadams5 59e9dd7
Change idf checks and clean up OutputProcessor test
mbadams5 2b49b0e
Update and clean up based on @kbenne comments
mbadams5 23535fb
Fix compare_containers usage to match documentation
mbadams5 460124d
Merge branch 'develop' into sqlite_timeseries
mbadams5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what is the analog if this if the namespaces were evolved into classes? Would you just destroy the object and recreate a new one. Or would you still have this method exposed publicly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You seem to be setting up a scenario where namespaces could become classes and perhaps their ctor take idf text or alternatively a data structure produced by your parser. ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of that view of the world. Data gets classified as time vary or not time varying. Class are instantiated with all not time varying data, possibly from idf parser. time varying data must be passed into and out of member functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think generally most of the namespace variables become member variables of a class and, yes, get recreated on any new object. There may be cases where this needs to be publicly exposed still, but I can't think of any off the top of my head.
Yes it would be nice if each class got instantiated by a data structure parsed by the InputProcessor. I'll address your comment about 'my' parser in a different comment.
I tend to agree with your 3rd comment.