Add extra validation to DateToStringWithMonth

When adding unit tests to this function I found it lacked validation
around edge cases. I refactored this function and now it passes all my
unit tests. This function probably never gets fed invalidate data
during an actual simulation but this makes the function more robust
anyways.

Author: mbadams5

src/EnergyPlus/OutputProcessor.cc

@@ -3422,65 +3422,76 @@ namespace OutputProcessor {
 		//   Convert the coded date format into a usable
 		//   string
 
-		// Using/Aliasing
-		using General::DecodeMonDayHrMin;
-
-		// Return value
-		std::string StringOut;
+		if ( codedDate == 0 ) return "-";
 
-		// Locals
-		// ((month*100 + day)*100 + hour)*100 + minute
 		static gio::Fmt DateFmt( "(I2.2,'-',A3,'-',I2.2,':',I2.2)" );
 
+		// ((month*100 + day)*100 + hour)*100 + minute
 		int Month; // month in integer format (1-12)
 		int Day; // day in integer format (1-31)
 		int Hour; // hour in integer format (1-24)
 		int Minute; // minute in integer format (0:59)
-		std::string monthName;
 
-		if ( codedDate != 0 ) {
-			monthName = "";
-			DecodeMonDayHrMin( codedDate, Month, Day, Hour, Minute );
-			--Hour;
-			if ( Minute == 60 ) {
-				++Hour;
-				Minute = 0;
-			}
-			if ( Month == 1 ) {
+		General::DecodeMonDayHrMin( codedDate, Month, Day, Hour, Minute );
+
+		if ( Month < 1 || Month > 12 ) return "-";
+		if ( Day < 1 || Day > 31 ) return "-";
+		if ( Hour < 1 || Hour > 24 ) return "-";
+		if ( Minute < 0 || Minute > 60 ) return "-";
+
+		--Hour;
+		if ( Minute == 60 ) {
+			++Hour;
+			Minute = 0;
+		}
+
+		std::string monthName;
+		switch ( Month ) {
+			case 1:
 				monthName = "JAN";
-			} else if ( Month == 2 ) {
+				break;
+			case 2:
 				monthName = "FEB";
-			} else if ( Month == 3 ) {
+				break;
+			case 3:
 				monthName = "MAR";
-			} else if ( Month == 4 ) {
+				break;
+			case 4:
 				monthName = "APR";
-			} else if ( Month == 5 ) {
+				break;
+			case 5:
 				monthName = "MAY";
-			} else if ( Month == 6 ) {
+				break;
+			case 6:
 				monthName = "JUN";
-			} else if ( Month == 7 ) {
+				break;
+			case 7:
 				monthName = "JUL";
-			} else if ( Month == 8 ) {
+				break;
+			case 8:
 				monthName = "AUG";
-			} else if ( Month == 9 ) {
+				break;
+			case 9:
 				monthName = "SEP";
-			} else if ( Month == 10 ) {
+				break;
+			case 10:
 				monthName = "OCT";
-			} else if ( Month == 11 ) {
+				break;
+			case 11:
 				monthName = "NOV";
-			} else if ( Month == 12 ) {
+				break;
+			case 12:
 				monthName = "DEC";
-			} else {
-				monthName = "***";
-			}
-			gio::write( StringOut, DateFmt ) << Day << monthName << Hour << Minute;
-			if ( has( StringOut, "*" ) ) {
-				StringOut = "-";
-			}
-		} else { // codeddate = 0
-			StringOut = "-";
+				break;
+			default:
+				assert( false );
+				monthName = "Should't get here!!";
+				break;
 		}
 
+		std::string StringOut;
+		gio::write( StringOut, DateFmt ) << Day << monthName << Hour << Minute;
+
 		return StringOut;
 	}