Relax error check for oa controller actuator node

[mjwitte]

Previously if the Controller:OutdoorAir actuator node was not on an OutdoorAir:Node list then this was a fatal error. Now it's just a warning to allow usage such as drawing OA from a preconditioning space such as a thermal labyrinth. Fixes #4272

GetOAControllerInputs was refactored to facilitate unit tests. Part of this routine was moved to ProcessOAControllerInputs. Unit tests were still a bit messy though requiring some additional setup, opening the err file, etc.

[jasondegraw]

@mjwitte I'm not sure why these are static (and StandardErrorOutput below). Is there a reason these aren't just:

bool ErrorsFound = false;
int ControllerNum = 0;

Maybe I am missing something.

[mjwitte]

@jasondegraw Good question. Probably because this is static here (which is what I copied to make this one):

https://github.com/NREL/EnergyPlus/blob/develop/tst/EnergyPlus/unit/HeatBalanceManager.unit.cc#L36

So, why are those static there? Because it's static here and I probably copy/pasted the declaration from here:

https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/HeatBalanceManager.cc#L327

And it's not clear to me that even the one in HeatBalanceManager needs to be static because GetHeatBalanceInput is only called once (fairly certain about that, but not completely).

[jasondegraw]

@mjwitte Looking around some it looks like static is getting used a lot elsewhere, too. So maybe the best thing is to get rid of the static modifier here and leave it alone elsewhere. It might be a bigger task to look at all of the uses of static than we want to get involved in right now. How does that sound to you?

[mjwitte]

@jasondegraw Sounds good. Done.

[jasondegraw]

@mjwitte I removed one more static, removed a local scope, and then added some deallocations of globals that @Myoldmopar wanted. I don't foresee any of those changing the all-green CI status, so I expect to merge this once the CI comes back

[mjwitte]

@jasondegraw Thanks for the cleanup.